replace DateRange with two DatePickers #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnichol
approved these changes
Jul 28, 2023
Contributor
tcnichol
left a comment
tcnichol
left a comment
There was a problem hiding this comment.
Looks good. Search returns results from within the range.
longshuicy
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #541 fix
This fixes a bug with reactivesearch's DateRange field that was causing infinite recursion trying to update the range according to the results returned from itself.
Implementing two individual DatePicker fields that have custom queries for gte/lte (Start/End Date) resolves this issue, seems to work as desired now.